linux-kernel - Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c8a51f44-937d-3cb7-82ad-0a42d9c7432d@au1.ibm.com>
Date:   Thu, 4 Oct 2018 21:59:01 +1000
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     zhong jiang <zhongjiang@...wei.com>, gregkh@...uxfoundation.org
Cc:     fbarrat@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference

On 4/10/18 3:02 pm, zhong jiang wrote:
> It is not safe to dereference an object before a null test. It is
> not needed and just remove them. Ftrace can be used instead.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Acked-by: Andrew Donnellan <andrew.donnellan@....ibm.com>

> ---
>   drivers/misc/cxl/guest.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..5d28d9e 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>   
>   void cxl_guest_remove_afu(struct cxl_afu *afu)
>   {
> -	pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
>   	if (!afu)
>   		return;
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited