linux-kernel - Re: [PATCH v7 12/14] sched/fair: Select an energy-efficient CPU on task wake-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181004121807.GO19272@hirez.programming.kicks-ass.net>
Date:   Thu, 4 Oct 2018 14:18:07 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Quentin Perret <quentin.perret@....com>
Cc:     rjw@...ysocki.net, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, gregkh@...uxfoundation.org,
        mingo@...hat.com, dietmar.eggemann@....com,
        morten.rasmussen@....com, chris.redpath@....com,
        patrick.bellasi@....com, valentin.schneider@....com,
        vincent.guittot@...aro.org, thara.gopinath@...aro.org,
        viresh.kumar@...aro.org, tkjos@...gle.com, joel@...lfernandes.org,
        smuckle@...gle.com, adharmap@...eaurora.org,
        skannan@...eaurora.org, pkondeti@...eaurora.org,
        juri.lelli@...hat.com, edubezval@...il.com,
        srinivas.pandruvada@...ux.intel.com, currojerez@...eup.net,
        javi.merino@...nel.org
Subject: Re: [PATCH v7 12/14] sched/fair: Select an energy-efficient CPU on
 task wake-up

On Thu, Oct 04, 2018 at 11:55:09AM +0100, Quentin Perret wrote:
> On Thursday 04 Oct 2018 at 12:41:07 (+0200), Peter Zijlstra wrote:
> > Not sure, see what it looks like ;-) My main concern here was to get rid
> > of that giant blob in select_task_rq_fair().
> 
> OK, got it. I'll probably just move the checks into the function and
> merge that large comment into the already massive comment above
> find_energy_efficient_cpu() or something. We'll see :-)
> 
> And do you actually care about the function name ? We've been using
> find_energy_efficient_cpu() for some time in Android now, so that's just
> slightly easier for us if that can be re-used. Not a big deal either,
> though.

Sure, that's fine I suppose.