linux-kernel - Re: [PATCHv1] RDMA/core: Check error status of rdma_find_ndev_for_src_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181004024812.GA18596@ziepe.ca>
Date:   Wed, 3 Oct 2018 20:48:12 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Parav Pandit <parav@...lanox.com>
Cc:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        Daniel Jurgens <danielj@...lanox.com>,
        "dledford@...hat.com" <dledford@...hat.com>
Subject: Re: [PATCHv1] RDMA/core: Check error status of
 rdma_find_ndev_for_src_ip_rcu

On Thu, Oct 04, 2018 at 02:28:54AM +0000, Parav Pandit wrote:
> Hi Doug, Jason,
> 
> > From: Parav Pandit <parav@...lanox.com>
> > Sent: Friday, September 21, 2018 10:00 AM
> > To: linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org;
> > leon@...nel.org; jgg@...pe.ca; syzkaller-bugs@...glegroups.com; Daniel
> > Jurgens <danielj@...lanox.com>; dledford@...hat.com
> > Cc: Parav Pandit <parav@...lanox.com>
> > Subject: [PATCHv1] RDMA/core: Check error status of
> > rdma_find_ndev_for_src_ip_rcu
> > 
> > rdma_find_ndev_for_src_ip_rcu() returns either valid netdev pointer or
> > ERR_PTR().
> > Instead of checking for NULL, check for error.
> > 
> > Fixes: caf1e3ae9fa6 ("RDMA/core Introduce and use
> > rdma_find_ndev_for_src_ip_rcu")
> > Reported-by: syzbot+20c32fa6ff84a2d28c36@...kaller.appspotmail.com
> > Signed-off-by: Parav Pandit <parav@...lanox.com>
> >  drivers/infiniband/core/addr.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
> > index c2ca9e4..3c07eeb 100644
> > +++ b/drivers/infiniband/core/addr.c
> > @@ -513,8 +513,8 @@ static int rdma_set_src_addr_rcu(struct
> > rdma_dev_addr *dev_addr,
> >  		 * loopback IP address.
> >  		 */
> >  		ndev = rdma_find_ndev_for_src_ip_rcu(dev_net(ndev),
> > dst_in);
> > -		if (!ndev)
> > -			return -ENODEV;
> > +		if (IS_ERR(ndev))
> > +			return PTR_ERR(ndev);
> >  	}
> > 
> >  	return copy_src_l2_addr(dev_addr, dst_in, dst, ndev);
> 
> Can you please review this fix?  I got below report from syzbot that
> it tested the patch and reproducer didn't trigger.

It is very strange, but this patch does not show up in rdma's patch
works.

This happened to Dennis as well for one patch, I'm afraid as a general
rule, people will need to check that patchworks has thier patches, and
maybe talk to LF IT about why things have gone missing. 

I would guess it is some spam filter issue?

I have applied this patch from my email.

Jason