linux-kernel - [PATCH] pinctrl: sirf: make const array rsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  4 Oct 2018 14:37:40 +0100
From:   Colin King <colin.king@...onical.com>
To:     Barry Song <baohua@...nel.org>, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] pinctrl: sirf: make const array rsc_ids static

From: Colin Ian King <colin.king@...onical.com>

The const array rsc_ids can be made static, saves populating it on
the stack and will make it read-only.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/pinctrl/sirf/pinctrl-sirf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c b/drivers/pinctrl/sirf/pinctrl-sirf.c
index 2e42d738b589..2a44b911018e 100644
--- a/drivers/pinctrl/sirf/pinctrl-sirf.c
+++ b/drivers/pinctrl/sirf/pinctrl-sirf.c
@@ -246,7 +246,7 @@ static struct pinctrl_desc sirfsoc_pinmux_desc = {
 
 static void __iomem *sirfsoc_rsc_of_iomap(void)
 {
-	const struct of_device_id rsc_ids[]  = {
+	static const struct of_device_id rsc_ids[]  = {
 		{ .compatible = "sirf,prima2-rsc" },
 		{}
 	};
-- 
2.17.1