linux-kernel - [PATCH v4 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1538666406-7504-2-git-send-email-jhugo@codeaurora.org>
Date:   Thu,  4 Oct 2018 09:20:05 -0600
From:   Jeffrey Hugo <jhugo@...eaurora.org>
To:     sudeep.holla@....com, gregkh@...uxfoundation.org,
        rjw@...ysocki.net, linux-acpi@...r.kernel.org,
        jeremy.linton@....com
Cc:     linux-kernel@...r.kernel.org, vkilari@...eaurora.org,
        Jeffrey Hugo <jhugo@...eaurora.org>
Subject: [PATCH v4 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types

If a cache has an unknown type because neither the hardware nor the
firmware told us, an entry in the sysfs tree will be made, but the type
file will not be present.  lscpu depends on the type file being present
for every entry, and will error out without printing system information
if lscpu cannot open the type file.

Presenting information about a cache without indicating its type is not
useful, therefore if we hit a cache with an unknown type, stop populating
sysfs so that userspace has the maximum amount of useful information.

This addresses the following lscpu error, which prevents any output.
lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
file or directory

Suggested-by: Sudeep Holla <sudeep.holla@....com>
Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
Reviewed-by: Jeremy Linton <jeremy.linton@....com>
Reviewed-by: Sudeep Holla <sudeep.holla@....com>
---
 drivers/base/cacheinfo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index 5d5b598..cf78fa6 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -615,6 +615,8 @@ static int cache_add_dev(unsigned int cpu)
 		this_leaf = this_cpu_ci->info_list + i;
 		if (this_leaf->disable_sysfs)
 			continue;
+		if (this_leaf->type == CACHE_TYPE_NOCACHE)
+			break;
 		cache_groups = cache_get_attribute_groups(this_leaf);
 		ci_dev = cpu_device_create(parent, this_leaf, cache_groups,
 					   "index%1u", i);
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.