[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181004154139.GA6921@kroah.com>
Date: Thu, 4 Oct 2018 08:41:39 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Jeffrey Hugo <jhugo@...eaurora.org>
Cc: sudeep.holla@....com, rjw@...ysocki.net,
linux-acpi@...r.kernel.org, jeremy.linton@....com,
linux-kernel@...r.kernel.org, vkilari@...eaurora.org
Subject: Re: [PATCH v4 1/2] drivers: base: cacheinfo: Do not populate sysfs
for unknown cache types
On Thu, Oct 04, 2018 at 09:20:05AM -0600, Jeffrey Hugo wrote:
> If a cache has an unknown type because neither the hardware nor the
> firmware told us, an entry in the sysfs tree will be made, but the type
> file will not be present. lscpu depends on the type file being present
> for every entry, and will error out without printing system information
> if lscpu cannot open the type file.
>
> Presenting information about a cache without indicating its type is not
> useful, therefore if we hit a cache with an unknown type, stop populating
> sysfs so that userspace has the maximum amount of useful information.
>
> This addresses the following lscpu error, which prevents any output.
> lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
> file or directory
>
> Suggested-by: Sudeep Holla <sudeep.holla@....com>
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> Reviewed-by: Jeremy Linton <jeremy.linton@....com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> ---
> drivers/base/cacheinfo.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists