linux-kernel - Re: [PATCH v2 RESEND] trace_uprobe: support reference counter in fd-based uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B4458A1-20B3-4BDE-9DCF-5E87EBD2D485@fb.com>
Date:   Thu, 4 Oct 2018 16:55:47 +0000
From:   Song Liu <songliubraving@...com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     lkml <linux-kernel@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        Oleg Nesterov <oleg@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 RESEND] trace_uprobe: support reference counter in
 fd-based uprobe



> On Oct 2, 2018, at 1:12 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> 
> On Mon, Oct 01, 2018 at 10:36:36PM -0700, Song Liu wrote:
>> Changes v1 -> v2: Fix PMU_FORMAT_ATTR as Peter suggested
>> 
>> This patch enables uprobes with reference counter in fd-based uprobe.
>> Highest 32 bits of perf_event_attr.config is used to stored offset
>> of the reference count (semaphore).
>> 
>> Format information in /sys/bus/event_source/devices/uprobe/format/ is
>> updated to reflect this new feature.
>> 
>> Signed-off-by: Song Liu <songliubraving@...com>
>> Reviewed-and-tested-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
>> Cc: Oleg Nesterov <oleg@...hat.com>
>> Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
> 
> Works for me,
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Thanks Peter!

Steven, could you please test/apply this? 

Best,
Song