linux-kernel - [PATCH v2 1/2] tty: wipe buffer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181004180614.25619-2-gregkh@linuxfoundation.org>
Date:   Thu,  4 Oct 2018 11:06:13 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-serial@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, jslaby@...e.com, aszlig@....build,
        gmazyland@...il.com, torvalds@...ux-foundation.org, w@....eu,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH v2 1/2] tty: wipe buffer.

From: Linus Torvalds <torvalds@...ux-foundation.org>

After we are done with the tty buffer, zero it out.

Reported-by: aszlig <aszlig@....build>
Tested-by: Milan Broz <gmazyland@...il.com>
Tested-by: aszlig <aszlig@....build>
Cc: Willy Tarreau <w@....eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
v2 - no change

 drivers/tty/tty_buffer.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index c996b6859c5e..ae3ce330200e 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -468,11 +468,15 @@ receive_buf(struct tty_port *port, struct tty_buffer *head, int count)
 {
 	unsigned char *p = char_buf_ptr(head, head->read);
 	char	      *f = NULL;
+	int n;
 
 	if (~head->flags & TTYB_NORMAL)
 		f = flag_buf_ptr(head, head->read);
 
-	return port->client_ops->receive_buf(port, p, f, count);
+	n = port->client_ops->receive_buf(port, p, f, count);
+	if (n > 0)
+		memset(p, 0, n);
+	return n;
 }
 
 /**
-- 
2.19.0