linux-kernel - Re: [PATCHv2] misc: cxl: delete possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181004043812.GA8134@kroah.com>
Date:   Wed, 3 Oct 2018 21:38:12 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     andrew.donnellan@....ibm.com, fbarrat@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] misc: cxl: delete possible null pointer dereference

On Thu, Oct 04, 2018 at 10:56:48AM +0800, zhong jiang wrote:
> It is safe to dereference an object below a NULL test. For the sake
> of debugging. Just delete the call of possible null pointer dereference.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/misc/cxl/guest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..472e8db 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,7 +1018,7 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>  
>  void cxl_guest_remove_afu(struct cxl_afu *afu)
>  {
> -	pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> +	pr_devel("in %s\n", __func__);

This call should just be deleted, it's not needed, ftrace can be used
instead.

thanks,

greg k-h