linux-kernel - Re: [PATCH] net/usb: cancel pending work when unbinding smsc75xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181004.135202.1340830794025516563.davem@davemloft.net>
Date:   Thu, 04 Oct 2018 13:52:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuzhao@...gle.com
Cc:     steve.glendinning@...well.net, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/usb: cancel pending work when unbinding smsc75xx

From: Yu Zhao <yuzhao@...gle.com>
Date: Fri, 28 Sep 2018 17:04:30 -0600

> Cancel pending work before freeing smsc75xx private data structure
> during binding. This fixes the following crash in the driver:
> 
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
> IP: mutex_lock+0x2b/0x3f
> <snipped>
> Workqueue: events smsc75xx_deferred_multicast_write [smsc75xx]
> task: ffff8caa83e85700 task.stack: ffff948b80518000
> RIP: 0010:mutex_lock+0x2b/0x3f
> <snipped>
> Call Trace:
>  smsc75xx_deferred_multicast_write+0x40/0x1af [smsc75xx]
>  process_one_work+0x18d/0x2fc
>  worker_thread+0x1a2/0x269
>  ? pr_cont_work+0x58/0x58
>  kthread+0xfa/0x10a
>  ? pr_cont_work+0x58/0x58
>  ? rcu_read_unlock_sched_notrace+0x48/0x48
>  ret_from_fork+0x22/0x40
> 
> Signed-off-by: Yu Zhao <yuzhao@...gle.com>

Applied and queued up for -stable.