linux-kernel - Re: [PATCH] ALSA: usb-audio: update quirk for B&W PX to remove microphone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7eixl9d9.wl-tiwai@suse.de>
Date:   Thu, 04 Oct 2018 22:55:46 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Nicolas Huaman" <nicolas@...ochao.de>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: update quirk for B&W PX to remove microphone

On Thu, 04 Oct 2018 16:42:05 +0200,
Nicolas Huaman wrote:
> 
> A quirk in snd-usb-audio was added to automate setting sample rate to
> 4800k and remove the previously exposed nonfunctional microphone for 
> the Bowers & Wilkins PX:
> commit 240a8af929c7c57dcde28682725b29cf8474e8e5
> https://lore.kernel.org/patchwork/patch/919689/
> 
> However the headphones where updated shortly after that to remove the
> unintentional microphone functionality. I guess because of this the
> headphones now crash when connecting them via USB while the quirk is
> active. Dmesg:
> 
> snd-usb-audio: probe of 2-3:1.0 failed with error -22
> usb 2-3: 2:1: cannot get min/max values for control 2 (id 2)
> 
> This patch removes the microfone and allows the headphones to connect 
> and work out of the box. It is based on the current mainline kernel 
>  and successfully applied an tested on my machine (4.18.10.arch1-1).
> 
> Signed-off-by: Nicolas Huaman <nicolas@...ochao.de>

Thanks, that looks much better now, and I can apply it.

But just to be sure: is any quirk required after the firmware update
on this device at all?  What happens if you remove the whole quirk?

If this modified quirk is still mandatory, I'll happily apply the
patch.


thanks,

Takashi