linux-kernel - Re: [PATCH] staging/rtlwifi: Fixing formatting warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe44162d-57de-2f5e-7cfb-ff0a15688c7c@embeddedor.com>
Date:   Fri, 5 Oct 2018 23:15:57 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Scott Tracy <scott.a.tracy@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/rtlwifi: Fixing formatting warnings.



On 10/5/18 10:58 PM, Scott Tracy wrote:
> Signed-off-by: Scott Tracy <scott.a.tracy@...il.com>
> ---
>  drivers/staging/rtlwifi/core.c  | 5 +++--
>  drivers/staging/rtlwifi/efuse.c | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
> index ca37f7511c4d..a36cb44a5388 100644
> --- a/drivers/staging/rtlwifi/core.c
> +++ b/drivers/staging/rtlwifi/core.c
> @@ -1109,7 +1109,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
>  			if (rtlpriv->dm.supp_phymode_switch) {
>  				if (sta->ht_cap.ht_supported)
>  					rtl_send_smps_action(hw, sta,
> -							     IEEE80211_SMPS_STATIC);
> +							IEEE80211_SMPS_STATIC);
>  			}
>  
>  			if (rtlhal->current_bandtype == BAND_ON_5G) {
> @@ -1882,7 +1882,8 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version,
>  				return true;
>  			default:
>  				WARN_ONCE(true,
> -					  "rtlwifi: %s(): Unknown CMD!!\n", __func__);
> +					 "rtlwifi: %s(): Unknown CMD!!\n",
> +					  __func__);
>  				break;
>  			}
>  		}
> diff --git a/drivers/staging/rtlwifi/efuse.c b/drivers/staging/rtlwifi/efuse.c
> index 1dc71455f270..5b8afdb3e0fe 100644
> --- a/drivers/staging/rtlwifi/efuse.c
> +++ b/drivers/staging/rtlwifi/efuse.c
> @@ -245,7 +245,8 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
>  	if (!efuse_word)
>  		goto out;
>  	for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {
> -		efuse_word[i] = kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);
> +		efuse_word[i] = kcalloc(efuse_max_section,
> +					sizeof(u16), GFP_ATOMIC);
>  		if (!efuse_word[i])
>  			goto done;
>  	}
> @@ -375,7 +376,7 @@ bool efuse_shadow_update_chk(struct ieee80211_hw *hw)
>  		for (i = 0; i < 8; i = i + 2) {
>  			if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
>  			     rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]) ||
> -			    (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
> +			   (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
>  			     rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
>  								   1])) {
>  				words_need++;
> 

Hi,

Please, always add a commit log explaining what exactly are you trying to fix.

Thanks
--
Gustavo