linux-kernel - Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_1qqdffE4K2BonCV0X_eYY+or6NSK9Bbco9A68N9aasVw@mail.gmail.com>
Date:   Fri, 5 Oct 2018 08:52:20 +0200
From:   Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Timur Tabi <timur@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

Hi
On Fri, Oct 5, 2018 at 12:26 AM Jeffrey Hugo <jhugo@...eaurora.org> wrote:
>
> On 10/2/2018 9:21 AM, Jeffrey Hugo wrote:
> > On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote:
> >> Current code assumes that the direction is input if direction_input
> >> function is set.
> >> This might not be the case on GPIOs with programmable direction.
> >>
> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> >
> > I'll try to get this series tested on QDF2400 by the end of the week.
>
> 1-2/3 (v3) and 3/3 (v4) still fails.  Same issue.  Attempting to access
> config registers for GPIO 0 when the OS is not allowed to do that.
>

I think that I might found the bug. if gpio-reserved-ranges was
present the initialization was lost.

Can you try with v5

Thanks for your help

> --
> Jeffrey Hugo
> Qualcomm Datacenter Technologies as an affiliate of Qualcomm
> Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.



-- 
Ricardo Ribalda