linux-kernel - Re: [PATCH v9 1/3]: perf util: map data buffer for preserving collected data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7e3f9be-152c-b038-96fa-3792a84b9347@linux.intel.com>
Date:   Fri, 5 Oct 2018 10:29:43 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, kernel-team@....com
Subject: Re: [PATCH v9 1/3]: perf util: map data buffer for preserving
 collected data

Hi,

On 05.10.2018 9:23, Namhyung Kim wrote:
<SNIP>
> On Wed, Oct 03, 2018 at 07:01:26PM +0300, Alexey Budankov wrote:
<SNIP>
>> +#ifdef HAVE_AIO_SUPPORT
>> +	map->nr_cblocks = mp->nr_cblocks;
>> +	if (map->nr_cblocks) {
>> +		map->data = malloc(perf_mmap__mmap_len(map));
>> +		if (!map->data) {
>> +			pr_debug2("failed to allocate data buffer, error %d\n",
>> +					errno);
> 
> I guess the error code is not very useful than the message.  But in
> this case it's probably ENOMEM so we can simply omit it.

Possibly like this:
			pr_debug2("failed to allocate data buffer, error %d: %s\n",
					errno, strerror(errno));
would be more informative.

Thanks,
Alexey