linux-kernel - Re: [PATCH] nvmem: lpc18xx_eeprom: fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Oct 2018 09:06:26 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Joachim Eastwood <manabian@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: lpc18xx_eeprom: fix compile warning



On 05/10/18 08:03, Gustavo A. R. Silva wrote:
> Fix the following warning by removing unused variable ret:
> 
> drivers/nvmem/lpc18xx_eeprom.c: In function ‘lpc18xx_eeprom_remove’:
> drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ‘ret’
> [-Wunused-variable]
>    int ret;
>        ^~~
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

There is already a patch submitted fix this

  https://lore.kernel.org/patchwork/patch/995032/


-srini

> ---
>   drivers/nvmem/lpc18xx_eeprom.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
> index b42dbad..66cff1e 100644
> --- a/drivers/nvmem/lpc18xx_eeprom.c
> +++ b/drivers/nvmem/lpc18xx_eeprom.c
> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
>   static int lpc18xx_eeprom_remove(struct platform_device *pdev)
>   {
>   	struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
> -	int ret;
>   
>   	clk_disable_unprepare(eeprom->clk);
>   
>