linux-kernel - Re: [PATCH] drm/gvt : fix error message typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <659e1b3d-8b17-e380-4196-340596ec9740@intel.com>
Date:   Fri, 5 Oct 2018 04:13:15 -0400
From:   Zhi Wang <zhi.a.wang@...el.com>
To:     Peng Hao <penghao122@...a.com.cn>, zhenyuw@...ux.intel.com,
        jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        airlied@...ux.ie
Cc:     intel-gvt-dev@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Peng Hao <peng.hao2@....com.cn>
Subject: Re: [PATCH] drm/gvt : fix error message typo

Hi:

Thanks for the patches. :) Several places needs to be improved:

1. The prefix of the patch should be: "drm/i915/gvt:".
2. You can just cc the maintainers of gvt since the gvt is a sub-module 
of i915.
3. Better refine the tittle of the patch and also the commit message. An 
informative title and commit message would be more friendly to people 
who reading this later, even it's only a small typo. :)

Again. Thanks for the patch. :) I will fix that for you and commit it, 
so you don't need to send it again.

Thanks,
Zhi.

On 10/04/18 12:04, Peng Hao wrote:
> 
> From: Peng Hao <peng.hao2@....com.cn>
> 
> gvt_err message typo.
> 
> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
> ---
>   drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c
> index 46c8b72..31d6809 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.c
> +++ b/drivers/gpu/drm/i915/gvt/gvt.c
> @@ -438,7 +438,7 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
>   
>   	ret = intel_gvt_debugfs_init(gvt);
>   	if (ret)
> -		gvt_err("debugfs registeration failed, go on.\n");
> +		gvt_err("debugfs registration failed, go on.\n");
>   
>   	gvt_dbg_core("gvt device initialization is done\n");
>   	dev_priv->gvt = gvt;
>