linux-kernel - Re: [PATCH] amdgpu/gmc : fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4772f72c-6018-3556-6324-5f49faa00073@roeck-us.net>
Date:   Fri, 5 Oct 2018 01:38:02 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Koenig, Christian" <Christian.Koenig@....com>,
        Peng Hao <peng.hao2@....com.cn>
Cc:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] amdgpu/gmc : fix compile warning

On 10/05/2018 01:14 AM, Koenig, Christian wrote:
> Am 04.10.2018 um 20:52 schrieb Guenter Roeck:
>> Hi,
>>
>> On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote:
>>> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:
>>>       In function ‘gmc_v8_0_process_interrupt’:
>>> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10:
>>>       warning: missing braces around initializer [-Wmissing-braces]
>>>
>>> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
>> Was there any feedback on this patch ? The problem does affect us,
>> and we'll need a fix.
> 
> Well as discussed using "{ { 0 } }" is as wrong as using "{ 0 }".
> 

Ah, sorry, I must have missed the discussion.

It is for sure not the best solution, but at least it compiles, and it seems
to be proliferating.

$ git grep "{ *{ *0 *} *}" | wc
     144    1180   11802
$ git grep "{ *{ *0 *} *}" drivers/gpu/drm/amd/ | wc
      50     459    5239

> We should either use only "{ }" or even better make nails with heads and
> use memset().

I'd rather leave it up to the compiler to decide what is most efficient.

Guenter

> 
> Christian.
> 
>>
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +-
>>>    drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>>>    2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
>>> index 9333109..55f4755 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
>>> @@ -1444,7 +1444,7 @@ static int gmc_v8_0_process_interrupt(struct amdgpu_device *adev,
>>>    		gmc_v8_0_set_fault_enable_default(adev, false);
>>>    
>>>    	if (printk_ratelimit()) {
>>> -		struct amdgpu_task_info task_info = { 0 };
>>> +		struct amdgpu_task_info task_info = { {0} };
>>>    
>> I wondered if
>> 		struct amdgpu_task_info task_info = { };
>> would be better.
>>
>> Thanks,
>> Guenter
>>
>>>    		amdgpu_vm_get_task_info(adev, entry->pasid, &task_info);
>>>    
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> index 72f8018..e8b78c5 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> @@ -259,7 +259,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
>>>    	}
>>>    
>>>    	if (printk_ratelimit()) {
>>> -		struct amdgpu_task_info task_info = { 0 };
>>> +		struct amdgpu_task_info task_info = { {0} };
>>>    
>>>    		amdgpu_vm_get_task_info(adev, entry->pasid, &task_info);
>>>    
>