linux-kernel - Re: [PATCH] mmc: tifm_sd: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Oct 2018 15:54:12 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Alex Dubov <oakad@...oo.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: tifm_sd: Mark expected switch fall-through

On 5 October 2018 at 11:54, Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case, I replaced the
> "deliberate fall-through" comment with a proper "fall through"
> at the bottom of the case, which is what GCC is expecting to find.
>
> Addresses-Coverity-ID: 1373887 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>


Applied for next, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/tifm_sd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tifm_sd.c b/drivers/mmc/host/tifm_sd.c
> index a3d8380..b6644ce 100644
> --- a/drivers/mmc/host/tifm_sd.c
> +++ b/drivers/mmc/host/tifm_sd.c
> @@ -336,7 +336,8 @@ static unsigned int tifm_sd_op_flags(struct mmc_command *cmd)
>                 rc |= TIFM_MMCSD_RSP_R0;
>                 break;
>         case MMC_RSP_R1B:
> -               rc |= TIFM_MMCSD_RSP_BUSY; // deliberate fall-through
> +               rc |= TIFM_MMCSD_RSP_BUSY;
> +               /* fall-through */
>         case MMC_RSP_R1:
>                 rc |= TIFM_MMCSD_RSP_R1;
>                 break;
> --
> 2.7.4
>