linux-kernel - Re: [PATCH V10 5/8] clocksource: add C-SKY SMP timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181005140319.GA6789@guoren-Inspiron-7460>
Date:   Fri, 5 Oct 2018 22:03:19 +0800
From:   Guo Ren <ren_guo@...ky.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
        robh+dt@...nel.org, mark.rutland@....com, anurup.m@...wei.com,
        Jonathan.Cameron@...wei.com, will.deacon@....com,
        zhangshaokun@...ilicon.com, jhogan@...nel.org,
        paul.burton@...s.com, peterz@...radead.org, arnd@...db.de,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH V10 5/8] clocksource: add C-SKY SMP timer

Hi Daniel,

On Fri, Oct 05, 2018 at 03:48:58PM +0200, Daniel Lezcano wrote:
> On 04/10/2018 19:22, Guo Ren wrote:
> > This timer is used by SMP system and use mfcr/mtcr instruction
> > to access the regs.
> > 
> > Changelog:
> >  - Add rollback for timer_of_cleanup.
> >  - Use request_percpu_irq separate from time_of.
> >  - Remove #define CPUHP_AP_CSKY_TIMER_STARTING.
> >  - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h.
> >  - Support csky mp timer alpha version.
> >  - Just use low-counter with 32bit width as clocksource.
> >  - Coding convention with upstream feed-back.
> > 
> > Signed-off-by: Guo Ren <ren_guo@...ky.com>
> > ---
> >  drivers/clocksource/Kconfig         |  10 +++
> >  drivers/clocksource/Makefile        |   1 +
> >  drivers/clocksource/timer-mp-csky.c | 173 ++++++++++++++++++++++++++++++++++++
> >  include/linux/cpuhotplug.h          |   1 +
> >  4 files changed, 185 insertions(+)
> >  create mode 100644 drivers/clocksource/timer-mp-csky.c
> > 
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index a11f4ba..826a2e8 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -620,4 +620,14 @@ config RISCV_TIMER
> >  	  is accessed via both the SBI and the rdcycle instruction.  This is
> >  	  required for all RISC-V systems.
> >  
> > +config CSKY_MP_TIMER
> > +	bool "SMP Timer for the C-SKY platform"
> > +	depends on CSKY
> > +	select TIMER_OF
> > +	help
> > +	  Say yes here to enable C-SKY SMP timer driver used for C-SKY SMP
> > +	  system.
> > +	  csky,mptimer is not only used in SMP system, it also could be used
> > +	  single core system. It's not a mmio reg and it use mtcr/mfcr instruction.
> 
> 
> ... COMPILE_TEST :)
Ops... I forgot it, should be: 
	bool "SMP Timer for the C-SKY platform" if COMPILE_TEST

Thx for remind and any other review is welcome.

Best Regards
 Guo Ren