linux-kernel - Re: [PATCH RT] tty: serial: pl011: fix warning about uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181005143530.o5g6kuh5i3ym44os@linutronix.de>
Date:   Fri, 5 Oct 2018 16:35:30 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH RT] tty: serial: pl011: fix warning about uninitialized
 variable

On 2018-09-24 10:29:01 [+0200], Kurt Kanzenbach wrote:
> Silence the following gcc warning:
> 
> drivers/tty/serial/amba-pl011.c: In function ‘pl011_console_write’:
> ./include/linux/spinlock.h:260:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    _raw_spin_unlock_irqrestore(lock, flags); \
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/tty/serial/amba-pl011.c:2214:16: note: ‘flags’ was declared here
>   unsigned long flags;
>                 ^~~~~
> 
> The code is correct. Thus, initializing flags to zero doesn't change the
> behavior and resolves the warning.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

applied.

Sebastian