linux-kernel - Re: [PATCH v3] sched/rt : return accurate release rq lock info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181005120959.6b8649e2@gandalf.local.home>
Date:   Fri, 5 Oct 2018 12:09:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     <peng.hao2@....com.cn>
Cc:     <andrea.parri@...rulasolutions.com>, <mingo@...hat.com>,
        <peterz@...radead.org>, <linux-kernel@...r.kernel.org>,
        <juri.lelli@...hat.com>
Subject: Re: [PATCH v3] sched/rt : return accurate release rq lock info

On Sat, 6 Oct 2018 00:03:58 +0800 (CST)
<peng.hao2@....com.cn> wrote:

> >Hi Peng,  
> 
> >On Sat, Oct 06, 2018 at 06:22:11AM +0800, Peng Hao wrote:  
> >> find_lock_lowest_rq may or not releease rq lock when return
> >> lowest_rq=NULL, but it is fuzzy.
> >> If not releasing rq lock, it is unnecessary to re-call
> >> pick_next_pushable_task.  
> 
> >IIRC, deadline.c uses a similar pattern (c.f., find_lock_later_rq() and
> >pick_next_pushable_dl_task()): should it be considered for this change?  
> peterz asked the same question.
> at first I thought dl's retry action is simple. But now  the change is simpler, I will
> add it. 
>

I would still do that as a separate patch though.

-- Steve