linux-kernel - [PATCH] [v2] interconnect: fix build error without DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20181005161438.801080-1-arnd@arndb.de>
Date:   Fri,  5 Oct 2018 18:14:26 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Georgi Djakov <georgi.djakov@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        YueHaibing <yuehaibing@...wei.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] [v2] interconnect: fix build error without DEBUGFS

The previous fix was incorrect, and now we get a build failure
without CONFIG_DEBUG_FS:

drivers/interconnect/core.c: In function 'icc_init':
drivers/interconnect/core.c:710:32: error: 'icc_summary_fops' undeclared (first use in this function)

Removing the last #ifdef as well makes it all work as intended.

Fixes: 8f023d0cb757 ("interconnect: core: Fix unused variable compiler warning")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
I had sent a different fix earlier, but that was done fore the
8f023d0cb757 commit got applied and conflicted with it, so this
new version should go on top.
---
 drivers/interconnect/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index ba48aa83a4ac..aac7bdd6c659 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -52,8 +52,6 @@ struct icc_path {
 	struct icc_req reqs[];
 };
 
-#ifdef CONFIG_DEBUG_FS
-
 static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
 {
 	if (!n)
@@ -106,7 +104,6 @@ static const struct file_operations icc_summary_fops = {
 	.llseek		= seq_lseek,
 	.release	= single_release,
 };
-#endif
 
 static struct icc_node *node_find(const int id)
 {
-- 
2.18.0