linux-kernel - Re: [PATCH 05/22] KEYS: Provide software public key query function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1810060423370.8957@namei.org>
Date:   Sat, 6 Oct 2018 04:23:54 +1000 (AEST)
From:   James Morris <jmorris@...ei.org>
To:     David Howells <dhowells@...hat.com>
cc:     denkenz@...il.com, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/22] KEYS: Provide software public key query function

On Sat, 6 Oct 2018, James Morris wrote:

> On Fri, 5 Oct 2018, David Howells wrote:
> 
> > James Morris <jmorris@...ei.org> wrote:
> > 
> > > > +	if (strcmp(encoding, "raw") == 0) {
> > > > +		strcpy(alg_name, pkey->pkey_algo);
> > > > +		return 0;
> > > > +	}
> > > 
> > > Can encoding here also be NULL to indicate raw? per patch 01:
> > 
> > Ummm...  By the letter of the documentation, yes, though in practice it isn't
> > (it is defaulted to "raw") in the keyctl interface.  I wonder if it would be
> > better to require it to say "raw" and never be NULL.
> 
> Probably.

If you respin the patches please add all the signoffs.

-- 
James Morris
<jmorris@...ei.org>