linux-kernel - Re: [PATCH] gigaset: asyncdata: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181005.115130.617036261938390310.davem@davemloft.net>
Date:   Fri, 05 Oct 2018 11:51:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     pebolle@...cali.nl, isdn@...ux-pingi.de,
        gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gigaset: asyncdata: mark expected switch fall-throughs

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Fri, 5 Oct 2018 15:29:09 +0200

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that in this particular case, I replaced the
> " --v-- fall through --v-- " comment with a proper
> "fall through", which is what GCC is expecting to find.
> 
> Addresses-Coverity-ID: 1364476 ("Missing break in switch")
> Addresses-Coverity-ID: 1364477 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied.