linux-kernel - Re: [PATCH v2] CIFS: Print message when attempting a mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Oct 2018 14:09:30 -0500
From:   Steve French <smfrench@...il.com>
To:     rfreire@...hat.com
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        Pavel Shilovsky <piastryyy@...il.com>
Subject: Re: [PATCH v2] CIFS: Print message when attempting a mount

On Tue, Oct 2, 2018 at 4:53 PM Rodrigo Freire <rfreire@...hat.com> wrote:
>
> Hi hi again Steve \o
>
> I do see potential for a ftrace rewrite for the cifs_dbg messages.

Was looking at this on current kernels and debugging mount is probably
fine for developers (or users) - plenty of debug messages get printed
via the dynamic ftrace points.  In practice some would prefer less
noisy trace logs so the minimum set for some would be something like
this (which already works with current cifs).  If we want to add some
default log messages on mount to dmesg instead of the trace-cmd log,
maybe we should log them at a slightly less noisy level (as we see
with xfs and btrfs) so they will be more log friendly


root@...-Thinkpad~/# trace-cmd record -e smb3_enter* -e smb3_exit*
Hit Ctrl^C to stop recording


root@...-Thinkpad:~/# trace-cmd show
# tracer: nop
#
#                              _-----=> irqs-off
#                             / _----=> need-resched
#                            | / _---=> hardirq/softirq
#                            || / _--=> preempt-depth
#                            ||| /     delay
#           TASK-PID   CPU#  ||||    TIMESTAMP  FUNCTION
#              | |       |   ||||       |         |
      mount.cifs-14199 [002] .... 97642.728411: smb3_enter:
cifs_mount: xid=20
      mount.cifs-14199 [002] .... 97642.728669: smb3_enter:
cifs_get_smb_ses: xid=21
      mount.cifs-14199 [003] .... 97642.742336: smb3_exit_done:
cifs_get_smb_ses: xid=21
      mount.cifs-14199 [003] .... 97642.742343: smb3_enter:
cifs_setup_ipc: xid=22
      mount.cifs-14199 [003] .... 97642.742530: smb3_exit_done:
cifs_setup_ipc: xid=22
      mount.cifs-14199 [003] .... 97642.742532: smb3_enter:
cifs_get_tcon: xid=23
      mount.cifs-14199 [003] .... 97642.742674: smb3_exit_done:
cifs_get_tcon: xid=23
      mount.cifs-14199 [003] .... 97642.743267: smb3_exit_done:
cifs_mount: xid=20
      mount.cifs-14199 [003] .... 97642.743311: smb3_enter:
cifs_root_iget: xid=24
      mount.cifs-14199 [003] .... 97642.743471: smb3_exit_done:
cifs_root_iget: xid=24




-- 
Thanks,

Steve