[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r2h2euuy.fsf@kamboji.qca.qualcomm.com>
Date: Sat, 06 Oct 2018 22:30:13 +0300
From: Kalle Valo <kvalo@...eaurora.org>
To: Colin King <colin.king@...onical.com>
Cc: Ping-Ke Shih <pkshih@...ltek.com>,
"David S . Miller" <davem@...emloft.net>,
Larry Finger <Larry.Finger@...inger.net>,
Tsang-Shian Lin <thlin@...ltek.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement
Colin King <colin.king@...onical.com> writes:
> From: Colin Ian King <colin.king@...onical.com>
>
> The switch case RATR_INX_WIRELESS_MC has a missing break, this seems
> to be unintentional as the setting of variable ret gets overwritten
> when the case falls through to the following RATR_INX_WIRELESS_AC_5N
> case. Fix this by adding in the missing break.
>
> Detected by CoverityScan, CID#1167237 ("Missing break in switch")
>
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 +
Is the fixes line correct? This patch is not for staging.
--
Kalle Valo
Powered by blists - more mailing lists