linux-kernel - Re: [PATCH] [PATCHv2 TRIVIAL] auxdisplay: remove unnecessary braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=9o+=4prkUNCogmz7D9vqNJj0fUZ93aBRfJzZs_Ni38w@mail.gmail.com>
Date:   Sat, 6 Oct 2018 22:59:22 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Ben Moore <benmoore422@...il.com>
Cc:     Willy Tarreau <w@....eu>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [PATCHv2 TRIVIAL] auxdisplay: remove unnecessary braces

Hi Ben,

On Sun, Sep 23, 2018 at 7:26 PM <benmoore422@...il.com> wrote:
> I have removed some unnecessary braces from if statements.
> As well as inspecting the other driverfiles for similar
> style issues.

Thanks for the new version!

> -       if (err) {
> +       if (err)
>                 dft_brightness = MAX_BRIGHTNESS;
> -       } else if (dft_brightness > MAX_BRIGHTNESS) {
> +       else if (dft_brightness > MAX_BRIGHTNESS) {

This one breaks the braces-if-the-other-branch-has-them that Geert
told you about:

  https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces

> -               if (byte & 1) {
> +               if (byte & 1)
>                         set_bit(LCD_BIT_DA, bits);
> -               } else {
> +               else
>                         clear_bit(LCD_BIT_DA, bits);
> -               }

This one seems fine.

Cheers,
Miguel