linux-kernel - Re: [PATCH v5 1/9] book3s/64: avoid circular header inclusion in mmu-hash.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a699e95-1f07-2ab1-47c2-84d7bce1bdda@c-s.fr>
Date:   Sun, 7 Oct 2018 18:43:26 +0200
From:   Christophe LEROY <christophe.leroy@....fr>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/9] book3s/64: avoid circular header inclusion in
 mmu-hash.h



Le 06/10/2018 à 14:47, Michael Ellerman a écrit :
> Christophe LEROY <christophe.leroy@....fr> writes:
> 
>> The serie has been successfully compiled tested at
>> http://kisskb.ellerman.id.au/kisskb/head/358723b36b126a381d827c82d04ee226321416b2/
> 
> I guess we need to turn on BPF_JIT in some configs :)
> 
> This works (builds), but not runtime tested:
> 
> diff --git a/arch/powerpc/net/bpf_jit32.h b/arch/powerpc/net/bpf_jit32.h
> index 6f4daacad296..dc50a8d4b3b9 100644
> --- a/arch/powerpc/net/bpf_jit32.h
> +++ b/arch/powerpc/net/bpf_jit32.h
> @@ -106,9 +106,8 @@ DECLARE_LOAD_FUNC(sk_load_byte_msh);
>   	} while (0)
>   #else
>   #define PPC_BPF_LOAD_CPU(r)     \
> -	do { BUILD_BUG_ON(FIELD_SIZEOF(struct thread_info, cpu) != 4);		\
> -		PPC_LHZ_OFFS(r, (1 & ~(THREAD_SIZE - 1)),			\
> -				offsetof(struct thread_info, cpu));		\
> +	do { BUILD_BUG_ON(FIELD_SIZEOF(struct task_struct, cpu) != 4);		\
> +		PPC_LHZ_OFFS(r, 2, offsetof(struct task_struct, cpu));		\
>   	} while(0)
>   #endif
>   #else
> 

Thanks, I'll take that.

Christophe