linux-kernel - Re: [PATCH] media: vivid: Support 480p for webcam capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181008160029.1bd1f5a8@coco.lan>
Date:   Mon, 8 Oct 2018 16:00:29 -0300
From:   Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
To:     Hans Verkuil <hverkuil@...all.nl>
Cc:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        Keiichi Watanabe <keiichiw@...omium.org>,
        linux-media@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org, tfiga@...omium.org,
        jcliang@...omium.org, shik@...omium.org
Subject: Re: [PATCH] media: vivid: Support 480p for webcam capture

Em Mon, 8 Oct 2018 20:31:10 +0200
Hans Verkuil <hverkuil@...all.nl> escreveu:

> > (gdb) list *vivid_fillbuff+0x1e9b
> > 0x1936b is in vivid_fillbuff (drivers/media/platform/vivid/vivid-kthread-cap.c:495).
> > 490					ms % 1000,
> > 491					buf->vb.sequence,
> > 492					(dev->field_cap == V4L2_FIELD_ALTERNATE) ?
> > 493						(buf->vb.field == V4L2_FIELD_TOP ?
> > 494						 " top" : " bottom") : "");
> > 495			tpg_gen_text(tpg, basep, line++ * line_height, 16, str);
> > 496		}
> > 497		if (dev->osd_mode == 0) {
> > 498			snprintf(str, sizeof(str), " %dx%d, input %d ",
> > 499					dev->src_rect.width, dev->src_rect.height, dev->input);
> >   
> 
> There is a bug with hflip handling in that function. Nothing to do with the
> resolution. I could reproduce it by just checking the hflip control.
> I'll investigate.

Ah! Well, as I said, I got it only once last week while trying to use
vivid for some event racing test. I didn't have time to actually
seek. On that time, the bug only manifested when I changed the frame
rate.

Thanks,
Mauro