linux-kernel - Re: [PATCH v2] staging: iio: ad2s1210: fix 'assignment operator' style checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 21:22:11 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matheus Tavares <matheus.bernardino@....br>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH v2] staging: iio: ad2s1210: fix 'assignment operator'
 style checks

On Mon,  8 Oct 2018 00:29:38 -0300
Matheus Tavares <matheus.bernardino@....br> wrote:

> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c with checkpatch.pl.
> 
> Signed-off-by: Matheus Tavares <matheus.bernardino@....br>
Great, thanks for sorting this out and coming back with a V2 so quickly.

Applied to the togreg branch of iio.git which is initially pushed out as
testing for the autobuilders to play with it.

We are late in the current kernel cycle, so this will probably not go
upstream until the merge window after the one that will open in a few
weeks time.

Thanks,

Jonathan

> ---
> Changes in v2: In v1, tabs were accidentally converted to whitespaces.
> Now, tabs were preserved.
> 
>  drivers/staging/iio/resolver/ad2s1210.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index ac13b99bd9cb..d4b1c2c010f2 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev,
>  			"ad2s1210: write control register fail\n");
>  		goto error_ret;
>  	}
> -	st->resolution
> -		= ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +	st->resolution =
> +		ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
>  	if (st->pdata->gpioin) {
>  		data = ad2s1210_read_resolution_pin(st);
>  		if (data != st->resolution)
> @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev,
>  		dev_err(dev, "ad2s1210: setting resolution fail\n");
>  		goto error_ret;
>  	}
> -	st->resolution
> -		= ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +	st->resolution =
> +		ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
>  	if (st->pdata->gpioin) {
>  		data = ad2s1210_read_resolution_pin(st);
>  		if (data != st->resolution)