linux-kernel - Re: [PATCH] kernel/panic: Do not append newline to the stack protector panic string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKkAf1z1bGjTNn7F-Qf=3eObFD4WS_BYgKONCHd-Ge5dw@mail.gmail.com>
Date:   Mon, 8 Oct 2018 14:57:48 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>
Subject: Re: [PATCH] kernel/panic: Do not append newline to the stack
 protector panic string

On Mon, Oct 8, 2018 at 1:29 PM, Borislav Petkov <bp@...en8.de> wrote:
> From: Borislav Petkov <bp@...e.de>
>
> ... because panic() itself already does this. Otherwise you have
> line-broken trailer:
>
>   [    1.836965] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: pgd_alloc+0x29e/0x2a0
>   [    1.836965]  ]---
>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: "Steven Rostedt (VMware)" <rostedt@...dmis.org>

Acked-by: Kees Cook <keescook@...omium.org>

Andrew, can you take this?

-Kees

> ---
>  kernel/panic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 8b2e002d52eb..837a94b7024d 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -631,7 +631,7 @@ device_initcall(register_warn_debugfs);
>   */
>  __visible void __stack_chk_fail(void)
>  {
> -       panic("stack-protector: Kernel stack is corrupted in: %pB\n",
> +       panic("stack-protector: Kernel stack is corrupted in: %pB",
>                 __builtin_return_address(0));
>  }
>  EXPORT_SYMBOL(__stack_chk_fail);
> --
> 2.19.0.271.gfe8321ec057f
>



-- 
Kees Cook
Pixel Security