linux-kernel - Re: [PATCH] netfilter: xt_quota: Don't use aligned attribute in sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181008222043.u7vnwbnwu7fx3m44@salvia>
Date:   Tue, 9 Oct 2018 00:20:43 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: xt_quota: Don't use aligned attribute in
 sizeof

On Sat, Oct 06, 2018 at 04:33:31PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> net/netfilter/xt_quota.c:47:44: warning: 'aligned' attribute ignored
> when parsing type [-Wignored-attributes]
>         BUILD_BUG_ON(sizeof(atomic64_t) != sizeof(__aligned_u64));
>                                                   ^~~~~~~~~~~~~
> 
> Use 'sizeof(__u64)' instead, as the alignment doesn't affect the size
> of the type.

Applied, thanks.