linux-kernel - Re: UBSAN: Undefined behaviour in lib/radix-tree.c:123:14: member access within null pointer of type 'const struct radix_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <153904059900.119890.16426538034066391569@swboyd.mtv.corp.google.com>
Date:   Mon, 08 Oct 2018 16:16:39 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Mark Rutland <mark.rutland@....com>,
        Paul Menzel <pmenzel+linux-kernel@...gen.mpg.de>
Cc:     Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-kernel@...r.kernel.org
Subject: Re: UBSAN: Undefined behaviour in lib/radix-tree.c:123:14: member access
 within null pointer of type 'const struct radix_tree_node'

Quoting Mark Rutland (2018-07-20 01:31:02)
> In-Reply-To: <19427cc3-3372-9b02-4b92-096fbe328622@...gen.mpg.de>
> 
> On Fri, Jul 20, 2018 at 09:53:21AM +0200, Paul Menzel wrote:
> > Dear Linux folks,
> 
> Hi,
> 
> > Enabling the undefined behavior sanitizer and building GNU/Linux 4.18-rc5+
> > (with some unrelated commits) with GCC 8.1.0 from Debian Sid/unstable, the
> > warning below is shown.
> > 
> > > [    0.958688] ================================================================================
> > > [    0.959029] UBSAN: Undefined behaviour in lib/radix-tree.c:123:14
> 
> That's in get_slot_offset(), and I think this is addressed by the patch [1] I previously sent.
> 
> There are at least a couple of instances in the radix tree code, and I had
> intended to address them together, but I haven't had the chance over the last
> couple of weeks.
> 
> I will try to get back to that soon.

Do you have that reworked patch lying around somewhere? I ran into an
ubsan error in radix-tree today and patch [1] fixes things.

> [1] https://lkml.kernel.org/r/20180706134144.48446-1-mark.rutland@arm.com