linux-kernel - Re: [PATCH net 10/10] rxrpc: Fix the packet reception routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3985.1539042093@warthog.procyon.org.uk>
Date:   Tue, 09 Oct 2018 00:41:33 +0100
From:   David Howells <dhowells@...hat.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     dhowells@...hat.com, netdev@...r.kernel.org, pabeni@...hat.com,
        eric.dumazet@...il.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 10/10] rxrpc: Fix the packet reception routine

David Howells <dhowells@...hat.com> wrote:

>  struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *local,
>  					   struct rxrpc_sock *rx,
> -					   struct rxrpc_peer *peer,
> -					   struct rxrpc_connection *conn,
>  					   struct sk_buff *skb)
>  {
>  	struct rxrpc_skb_priv *sp = rxrpc_skb(skb);
> +	struct rxrpc_connection *conn;
> +	struct rxrpc_peer *peer;

'peer' needs to be initialised to NULL here to prevent an oops later if we
fail to look the peer up.

	-	struct rxrpc_peer *peer;
	+	struct rxrpc_peer *peer = NULL;

I've repushed the branch with a new tag rxrpc-fixes-20181008-b if you could
pull that instead.  I can repost the series if you'd prefer.

David