linux-kernel - CHECKPATCH: strange warning on alignment modifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <15d77776-0551-5b7d-935e-16496c3800e2@gmail.com>
Date:   Mon, 8 Oct 2018 10:56:10 +0300
From:   Igor Stoppa <igor.stoppa@...il.com>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: CHECKPATCH: strange warning on alignment modifier

Hi,

I have the following fragment of code:

+struct my_struct {
+       atomic_long_t l __aligned(sizeof(atomic_long_t));
+} __aligned(sizeof(atomic_long_t));

triggering this warning, when fed to checkpatch.pl:

WARNING: function definition argument 'atomic_long_t' should also have 
an identifier name
#19: FILE: path/to/file.h
+	atomic_long_t l __aligned(sizeof(atomic_long_t));

gcc [(Ubuntu 7.3.0-16ubuntu3) 7.3.0] seems to be happy about it

I am using the HEAD from mainline.

My intent is to specify the alignment of both the field and the 
structure (yes, probably redundant in this single-field case).

If I am doing something wrong, I can't figure out what it is, but I 
don't understand why the WARNING is mentioning a function definition.

--
igor