lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Oct 2018 10:00:13 +0200 From: Borislav Petkov <bp@...e.de> To: lijiang <lijiang@...hat.com> Cc: linux-kernel@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de, hpa@...or.com, linux-tip-commits@...r.kernel.org Subject: Re: [tip:x86/mm] kdump, proc/vmcore: Enable kdumping encrypted memory with SME enabled On Mon, Oct 08, 2018 at 03:11:56PM +0800, lijiang wrote: > I used this ".config" to compile kernel in the attachment, and got a compile error. > Would you like to have a try? > > [root@...dl385g10-03 linux]# make ARCH=i386 -j32 > ...... > LD vmlinux.o > MODPOST vmlinux.o > fs/proc/vmcore.o:In function ‘read_from_oldmem’: > /home/linux/fs/proc/vmcore.c:127:undefined reference to ‘copy_oldmem_page_encrypted’ > make: *** [vmlinux] error 1 Thanks, that triggered here. Ok, I guess something like this, to avoid the ugly ifdeffery: --- diff --git a/arch/x86/kernel/crash_dump_32.c b/arch/x86/kernel/crash_dump_32.c index 33ee47670b99..8696800f2eea 100644 --- a/arch/x86/kernel/crash_dump_32.c +++ b/arch/x86/kernel/crash_dump_32.c @@ -80,6 +80,16 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf, return csize; } +/* + * 32-bit parrot version to avoid build errors. + */ +ssize_t copy_oldmem_page_encrypted(unsigned long pfn, char *buf, size_t csize, + unsigned long offset, int userbuf) +{ + WARN_ON_ONCE(1); + return copy_oldmem_page(pfn, buf, csize, offset, userbuf); +} + static int __init kdump_buf_page_init(void) { int ret = 0; -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Powered by blists - more mailing lists