linux-kernel - RE: [PATCH v2 10/11] arch/x86: Add AMD feature bit X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR12MB247180925D3E9D4C2A8E04D795E60@DM5PR12MB2471.namprd12.prod.outlook.com>
Date:   Mon, 8 Oct 2018 01:25:36 +0000
From:   "Moger, Babu" <Babu.Moger@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "reinette.chatre@...el.com" <reinette.chatre@...el.com>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "vikas.shivappa@...ux.intel.com" <vikas.shivappa@...ux.intel.com>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "xiaochen.shen@...el.com" <xiaochen.shen@...el.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "Hurwitz, Sherry" <sherry.hurwitz@....com>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "luto@...nel.org" <luto@...nel.org>,
        "jroedel@...e.de" <jroedel@...e.de>,
        "jannh@...gle.com" <jannh@...gle.com>,
        "dima@...sta.com" <dima@...sta.com>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 10/11] arch/x86: Add AMD feature bit X86_FEATURE_MBA in
 cpuid bits array



> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Friday, October 5, 2018 4:31 PM
> To: Moger, Babu <Babu.Moger@....com>
> Cc: tglx@...utronix.de; mingo@...hat.com; hpa@...or.com;
> reinette.chatre@...el.com; fenghua.yu@...el.com; james.morse@....com;
> vikas.shivappa@...ux.intel.com; tony.luck@...el.com; x86@...nel.org;
> peterz@...radead.org; pombredanne@...b.com;
> gregkh@...uxfoundation.org; kstewart@...uxfoundation.org;
> rafael.j.wysocki@...el.com; ak@...ux.intel.com;
> kirill.shutemov@...ux.intel.com; xiaochen.shen@...el.com;
> colin.king@...onical.com; Hurwitz, Sherry <sherry.hurwitz@....com>;
> Lendacky, Thomas <Thomas.Lendacky@....com>; pbonzini@...hat.com;
> dwmw@...zon.co.uk; luto@...nel.org; jroedel@...e.de;
> jannh@...gle.com; dima@...sta.com; jpoimboe@...hat.com;
> vkuznets@...hat.com; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 10/11] arch/x86: Add AMD feature bit
> X86_FEATURE_MBA in cpuid bits array
> 
> On Fri, Oct 05, 2018 at 08:56:09PM +0000, Moger, Babu wrote:
> > From: Sherry Hurwitz <sherry.hurwitz@....com>
> >
> > The feature bit X86_FEATURE_MBA is detected via CPUID leaf 0x80000008
> > EBX Bit 06. This bit indicates the support of AMD's MBA feature.
> >
> > This feature is supported by both Intel and AMD. But they are detected
> > different CPUID leaves.
> >
> > Signed-off-by: Babu Moger <babu.moger@....com>
> > Signed-off-by: Sherry Hurwitz <sherry.hurwitz@....com>
> 
> This SOB chain should be the other way around - first Sherry, then you.

Sure. Will change it.
> 
> > ---
> >  arch/x86/kernel/cpu/scattered.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/scattered.c
> b/arch/x86/kernel/cpu/scattered.c
> > index 772c219b6889..bd7853334b27 100644
> > --- a/arch/x86/kernel/cpu/scattered.c
> > +++ b/arch/x86/kernel/cpu/scattered.c
> > @@ -17,7 +17,11 @@ struct cpuid_bit {
> >  	u32 sub_leaf;
> >  };
> >
> > -/* Please keep the leaf sorted by cpuid_bit.level for faster search. */
> > +/*
> > + * Please keep the leaf sorted by cpuid_bit.level for faster search.
> > + * X86_FEATURE_MBA supported by both Intel and AMD. But the cpuid
> > + * levels are different. Add a separate enty for each.
> > + */
> >  static const struct cpuid_bit cpuid_bits[] = {
> >  	{ X86_FEATURE_APERFMPERF,       CPUID_ECX,  0, 0x00000006, 0 },
> >  	{ X86_FEATURE_EPB,		CPUID_ECX,  3, 0x00000006, 0 },
> > @@ -29,6 +33,7 @@ static const struct cpuid_bit cpuid_bits[] = {
> >  	{ X86_FEATURE_HW_PSTATE,	CPUID_EDX,  7, 0x80000007, 0 },
> >  	{ X86_FEATURE_CPB,		CPUID_EDX,  9, 0x80000007, 0 },
> >  	{ X86_FEATURE_PROC_FEEDBACK,    CPUID_EDX, 11, 0x80000007, 0 },
> > +	{ X86_FEATURE_MBA,		CPUID_EBX,  6, 0x80000008, 0 },
> >  	{ X86_FEATURE_SME,		CPUID_EAX,  0, 0x8000001f, 0 },
> >  	{ X86_FEATURE_SEV,		CPUID_EAX,  1, 0x8000001f, 0 },
> >  	{ 0, 0, 0, 0, 0 }
> > --
> 
> With that fixed:
> 
> Reviewed-by: Borislav Petkov <bp@...e.de>
> 

Thanks

> --
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.