linux-kernel - Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 12:41:11 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings


On 08/25/2018 08:23 PM, Sam Ravnborg wrote:
> When a device tree set a display-timing using native-mode
> then according to the bindings doc this should:
> 
>     native-mode:
>     The native mode for the display, in case multiple
>     modes are provided.
>     When omitted, assume the first node is the native.
> 
> The atmel_lcdfb used the last timing subnode and did not
> respect the timing mode specified with native-mode.
> 
> Introduce use of of_get_videomode() which allowed
> a nice simplification of the code while also
> added support for native-mode.
> 
> As a nice side-effect this fixes a memory leak where the
> data used for timings and the display_np was not freed.
> 
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics