linux-kernel - Re: [PATCH 1/6] dt-bindings: phy: am654-mmc-phy: Document new phy bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 13:29:55 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Faiz Abbas <faiz_abbas@...com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Kishon <kishon@...com>, Rob Herring <robh+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 1/6] dt-bindings: phy: am654-mmc-phy: Document new phy bindings

[...]

> +Host controller node:
> +
> +                       sdhci1: sdhci@0 {
> +                               compatible = "ti,am654-sdhci-5.1";
> +                               reg = <0x0 0x1000>;
> +                               power-domains = <&k3_pds 48>;
> +                               clocks = <&k3_clks 48 0>, <&k3_clks 48 1>;
> +                               clock-names = "clk_ahb", "clk_xin";
> +                               interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> +                               clock-output-names = "mmc_cardclck";

mmc_cardclk

> +                               #clock-cells = <0>;
> +                               phys=<&mmc_phy1>;
> +                               phy-names = "phy_arasan";
> +                               status = "disabled";
> +                       };
> --
> 2.18.0
>

Besides the nitpick and the comments from Andrew, this looks good to me.

Kind regards
Uffe