linux-kernel - Re: [PATCH v11 2/3]: perf record: enable asynchronous trace writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f598a308-464a-635a-9310-d9aaead88a14@linux.intel.com>
Date:   Mon, 8 Oct 2018 15:17:57 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 2/3]: perf record: enable asynchronous trace writing

Hi,

On 08.10.2018 13:50, Jiri Olsa wrote:
> On Mon, Oct 08, 2018 at 09:17:11AM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> -
>> +#ifdef HAVE_AIO_SUPPORT
>> +	lseek(trace_fd, off, SEEK_SET);
>> +#endif
>>  	/*
>>  	 * Mark the round finished in case we wrote
>>  	 * at least one event.
>> @@ -650,6 +799,9 @@ record__switch_output(struct record *rec, bool at_exit)
>>  	/* Same Size:      "2015122520103046"*/
>>  	char timestamp[] = "InvalidTimestamp";
>>  
>> +#ifdef HAVE_AIO_SUPPORT
>> +	record__mmap_read_sync(rec);
>> +#endif
> 
> same, please define the record__mmap_read_sync dummy
> so we can skip that #ifdef #endif

Accepted.

> 
>>  	record__synthesize(rec, true);
>>  	if (target__none(&rec->opts.target))
>>  		record__synthesize_workload(rec, true);
>> @@ -1157,6 +1309,10 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
>>  		record__synthesize_workload(rec, true);
>>  
>>  out_child:
>> +
>> +#ifdef HAVE_AIO_SUPPORT
>> +	record__mmap_read_sync(rec);
>> +#endif
> 
> ditto

Accepted.

Thanks,
Alexey

> 
> thanks,
> jirka
> 
> SNIP
>