linux-kernel - Re: [RFC PATCH 9/9] leds: lm3632: Introduce the TI LM3632 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b323e344-f8e5-1a29-9ea3-56499d41ba89@ti.com>
Date:   Mon, 8 Oct 2018 07:23:13 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <jacek.anaszewski@...il.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lee.jones@...aro.org>, <linux-omap@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [RFC PATCH 9/9] leds: lm3632: Introduce the TI LM3632 driver

Pavel

On 10/07/2018 08:46 AM, Pavel Machek wrote:
> On Wed 2018-09-26 08:09:21, Dan Murphy wrote:
>> Add the dedicated TI LM3632 LED driver.  This
>> LED device is capable of driving a backlight display.
>>
>> In addition to the backlight the device has control
>> of a strobe and torch output.
> 
> Is this in some way similar to 3639? That also seems to include flash
> and torch.
> 
> drivers/video/backlight/lm3639_bl.c
> 	

NICE!  

Yes this driver looks to be good enough to use for the 3632 as well.

We would have to extend that driver to support the 3632, add firmware support,
convert the led class registration to the flash LED registration and add the regulator support.

I can abandon the dedicated LED driver and update this one for the 3632.
No reason to have duplicate code.

Dan

							Pavel
> 


-- 
------------------
Dan Murphy