linux-kernel - Re: [PATCH trivial] reset: Improve reset controller kernel docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1539003340.11512.18.camel@pengutronix.de>
Date:   Mon, 08 Oct 2018 14:55:40 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Jiri Kosina <trivial@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH trivial] reset: Improve reset controller kernel docs

Hi Geert,

On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote:
> Grammar and indentation fixes.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  include/linux/reset.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
>   *
>   * Returns a struct reset_control or IS_ERR() condition containing errno.
>   * This function is intended for use with reset-controls which are shared
> - * between hardware-blocks.
> + * among hardware blocks.

To my ears "between" sounds better, because it evokes the idea that each
hardware block individually must take care not to disturb any of the
others (like sharing a bike between a few riders, instead of among
them). Also, in many cases the sharing occurs between just two hardware
blocks, which makes "among" sound weird.
Of course I'm not a native speaker, so maybe I'm completely wrong.

The other fixes I agree with.

regards
Philipp