linux-kernel - Re: [PATCH v4 1/2] spi: Add MXIC controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181008133752.GF5684@sirena.org.uk>
Date:   Mon, 8 Oct 2018 14:37:52 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     masonccyang@...c.com.tw, tpiepho@...inj.com,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        juliensu@...c.com.tw, zhengxunli@...c.com.tw
Subject: Re: [PATCH v4 1/2] spi: Add MXIC controller driver

On Mon, Oct 08, 2018 at 10:38:12AM +0200, Boris Brezillon wrote:

> This is wrong, ->cur_speed_hz should be updated in
> mxic_prepare_transfer_hardware() or mxic_spi_clk_check(), not when
> ->setup() is called. Also, you seem to ignore the xfer->speed_hz value,
> which might be different from spi->max_speed_hz. Maybe the
> ->prepare_transfer() hook is not the right place to do this
> ->cur_speed_hz selection in the end.

xfer->speed_hz should always be filled in so it's the only one you need
to pay attention to (as the code Boris proposed does).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)