linux-kernel - Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181008131944.GB20703@kroah.com>
Date:   Mon, 8 Oct 2018 15:19:44 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Adam Borowski <kilobyte@...band.pl>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD

On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
> A spanking new machine I just got has all but one USB ports wired as 3.0.
> Booting defconfig resulted in no keyboard or mouse, which was pretty
> uncool.  Let's enable that -- USB3 is ubiquitous rather than an oddity.
> As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
> 
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
>  arch/x86/configs/x86_64_defconfig | 1 +
>  1 file changed, 1 insertion(+)

defconfig for x86 actually still works?  That's amazing in itself :)

> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index e32fc1f274d8..ac9ae487cfeb 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
>  CONFIG_USB=y
>  CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>  CONFIG_USB_MON=y
> +CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_EHCI_TT_NEWSCHED=y
>  CONFIG_USB_OHCI_HCD=y

You can probably turn ehci and ohci off if you have xhci in the
"default" system now.

thanks,

greg k-h