linux-kernel - Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8973680e-4391-48cf-e979-1e9a10be0968@intel.com>
Date:   Mon, 8 Oct 2018 11:50:50 -0400
From:   Dennis Dalessandro <dennis.dalessandro@...el.com>
To:     john.hubbard@...il.com, Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>,
        Christopher Lameter <cl@...ux.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Dan Williams <dan.j.williams@...el.com>,
        Jan Kara <jack@...e.cz>
Cc:     linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org, John Hubbard <jhubbard@...dia.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Jerome Glisse <jglisse@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        Ralph Campbell <rcampbell@...dia.com>
Subject: Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps

On 10/5/2018 10:49 PM, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> Changes since v2:
> 
> -- Absorbed more dirty page handling logic into the put_user_page*(), and
>     handled some page releasing loops in infiniband more thoroughly, as per
>     Jason Gunthorpe's feedback.
> 
> -- Fixed a bug in the put_user_pages*() routines' loops (thanks to
>     Ralph Campbell for spotting it).
> 
> Changes since v1:
> 
> -- Renamed release_user_pages*() to put_user_pages*(), from Jan's feedback.
> 
> -- Removed the goldfish.c changes, and instead, only included a single
>     user (infiniband) of the new functions. That is because goldfish.c no
>     longer has a name collision (it has a release_user_pages() routine), and
>     also because infiniband exercises both the put_user_page() and
>     put_user_pages*() paths.
> 
> -- Updated links to discussions and plans, so as to be sure to include
>     bounce buffers, thanks to Jerome's feedback.
> 
> Also:
> 
> -- Dennis, thanks for your earlier review, and I have not yet added your
>     Reviewed-by tag, because this revision changes the things that you had
>     previously reviewed, thus potentially requiring another look.

This spin looks fine to me.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...el.com>