linux-kernel - Re: [PATCH] video: fbdev: remove redundant 'default n' from Kconfig-s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84e7faee-234e-5640-1c25-83f152bc19a9@infradead.org>
Date:   Mon, 8 Oct 2018 08:54:10 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: remove redundant 'default n' from Kconfig-s

On 10/8/18 8:40 AM, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
> 
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
> 
>     ...
>     One side effect of (and the main motivation for) this change is making
>     the following two definitions behave exactly the same:
>     
>         config FOO
>                 bool
>     
>         config FOO
>                 bool
>                 default n

	config FOO
		def_bool n

is a good substitute, especially for non-prompt symbols. (IMHO)

>     With this change, neither of these will generate a
>     '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
>     That might make it clearer to people that a bare 'default n' is
>     redundant.
>     ...
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  drivers/video/fbdev/Kconfig                  |   28 ---------------------------
>  drivers/video/fbdev/mmp/hw/Kconfig           |    1 
>  drivers/video/fbdev/mmp/panel/Kconfig        |    1 
>  drivers/video/fbdev/omap2/omapfb/dss/Kconfig |    7 ------
>  4 files changed, 37 deletions(-)

thanks.
-- 
~Randy