linux-kernel - [PATCH] regulator: bd718x7: include linux/of.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon,  8 Oct 2018 18:14:32 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Axel Lin <axel.lin@...ics.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] regulator: bd718x7: include linux/of.h

Without this header, we get a lengthy build error:

drivers/regulator/bd718x7-regulator.c:364:16: error: implicit declaration of function 'of_match_ptr'; did you mean 'hash_ptr'? [-Werror=implicit-function-declaration]
    .of_match = of_match_ptr("BUCK1"),
                ^~~~~~~~~~~~
                hash_ptr
drivers/regulator/bd718x7-regulator.c:364:16: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
drivers/regulator/bd718x7-regulator.c:364:16: note: (near initialization for 'bd71847_regulators[0].desc.of_match')
drivers/regulator/bd718x7-regulator.c:364:16: error: initializer element is not constant
drivers/regulator/bd718x7-regulator.c:364:16: note: (near initialization for 'bd71847_regulators[0].desc.of_match')
drivers/regulator/bd718x7-regulator.c:365:23: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
...

Fixes: 2ece646c90c5 ("regulator: bd718xx: rename bd71837 to 718xx")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/regulator/bd718x7-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c
index d2522d4e1505..7bf25aafe077 100644
--- a/drivers/regulator/bd718x7-regulator.c
+++ b/drivers/regulator/bd718x7-regulator.c
@@ -9,6 +9,7 @@
 #include <linux/kernel.h>
 #include <linux/mfd/rohm-bd718x7.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
-- 
2.18.0