linux-kernel - Re: [PATCH] scsi/mpt3sas: Use dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 21:58:26 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     sathya.prakash@...adcom.com, chaitra.basappa@...adcom.com,
        suganath-prabu.subramani@...adcom.com,
        James Bottomley <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Cc:     MPT-FusionLinux.pdl@...adcom.com,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi/mpt3sas: Use dma_pool_zalloc

On Tue, Oct 2, 2018 at 11:14 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> Replaced dma_pool_alloc + memset with dma_pool_zalloc.
>
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Any comment on this patch ?
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 59d7844..d7ef671 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
>         i = 0;
>         do {
>                 ioc->reply_post[i].reply_post_free =
> -                   dma_pool_alloc(ioc->reply_post_free_dma_pool,
> +                   dma_pool_zalloc(ioc->reply_post_free_dma_pool,
>                     GFP_KERNEL,
>                     &ioc->reply_post[i].reply_post_free_dma);
>                 if (!ioc->reply_post[i].reply_post_free) {
> @@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
>                         ioc->name);
>                         goto out;
>                 }
> -               memset(ioc->reply_post[i].reply_post_free, 0, sz);
>                 dinitprintk(ioc, pr_info(MPT3SAS_FMT
>                     "reply post free pool (0x%p): depth(%d),"
>                     "element_size(%d), pool_size(%d kB)\n", ioc->name,
> @@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
>                         ioc->name);
>                 goto out;
>         }
> -       ioc->reply_free = dma_pool_alloc(ioc->reply_free_dma_pool, GFP_KERNEL,
> +       ioc->reply_free = dma_pool_zalloc(ioc->reply_free_dma_pool, GFP_KERNEL,
>             &ioc->reply_free_dma);
>         if (!ioc->reply_free) {
>                 pr_err(MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n",
>                         ioc->name);
>                 goto out;
>         }
> -       memset(ioc->reply_free, 0, sz);
>         dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply_free pool(0x%p): " \
>             "depth(%d), element_size(%d), pool_size(%d kB)\n", ioc->name,
>             ioc->reply_free, ioc->reply_free_queue_depth, 4, sz/1024));
> --
> 1.9.1
>