linux-kernel - Re: [PATCH] media: tc358743: Remove unnecessary self assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Oct 2018 22:09:31 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Mats Randgaard <matrandg@...co.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: tc358743: Remove unnecessary self assignment

Hi Nathan,

Thank you for the patch,

On 08/10/18 23:11, Nathan Chancellor wrote:
> Clang warns when a variable is assigned to itself.
> 
> drivers/media/i2c/tc358743.c:1921:7: warning: explicitly assigning value
> of variable of type 'int' to itself [-Wself-assign]
>                 ret = ret;
>                 ~~~ ^ ~~~
> 1 warning generated.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Certainly somewhat redundant.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> ---
>  drivers/media/i2c/tc358743.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index ca5d92942820..41d470d9ca94 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1918,7 +1918,6 @@ static int tc358743_probe_of(struct tc358743_state *state)
>  	ret = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep), &endpoint);
>  	if (ret) {
>  		dev_err(dev, "failed to parse endpoint\n");
> -		ret = ret;
>  		goto put_node;
>  	}
>  
>