linux-kernel - Re: [PATCH v3] ARM: dts: imx6sx-sdb: Fix enet phy regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e4fd39e1e2271f12f6f11fe644cad7c93d1d363.camel@nxp.com>
Date:   Tue, 9 Oct 2018 23:00:00 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Andy Duan <fugang.duan@....com>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v3] ARM: dts: imx6sx-sdb: Fix enet phy regulator

On Tue, 2018-10-09 at 09:09 +0800, Shawn Guo wrote:
> On Mon, Oct 08, 2018 at 03:28:01PM +0000, Leonard Crestez wrote:
> > Bindings for "fixed-regulator" only explicitly support "gpio" property,
> > not "gpios". Fix by correcting the property name.
> > 
> > The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power
> > cycle, this can be handled by the phy-reset-gpios property. Sadly this
> > is not handled on suspend: the fec driver turns phy-supply off but
> > doesn't assert phy-reset-gpios again on resume.
> > 
> > Since additional phy-level work is required to support powering off the
> > phy in suspend fix the problem by just marking the regulator as
> > "boot-on" "always-on" so that it's never turned off. This behavior is
> > equivalent to older releases.
> > 
> > Keep the phy-reset-gpios property on fec anyway because it is a correct
> > description of board design.
> > 
> > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
> > Convert to use GPIO descriptor only") which causes the "gpios" property
> > to also be parsed. Before that commit the "gpios" property had no
> > effect, PHY reset was only handled in the the bootloader.

> So this is a fix we only need to apply for 4.20-rc, right?

Yes.

This issue was exposed by gpio changes for 4.20 but 4.19 RCs are fine.

--
Regards,
Leonard